Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kine to v0.13.2 #10978

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Bump kine to v0.13.2 #10978

merged 2 commits into from
Oct 3, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Oct 2, 2024

Proposed Changes

Bump kine version to v0.13.2 for sql library version bumps:

Types of Changes

version bump

Verification

check version in go.mod

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner October 2, 2024 21:38
Support for 'sqlite' as the endpoint was removed in
k3s-io/kine#320 and the constant removed in
k3s-io/kine#325

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.09%. Comparing base (6c6d87d) to head (9352f55).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
pkg/etcd/etcd.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6c6d87d) and HEAD (9352f55). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6c6d87d) HEAD (9352f55)
e2etests 7 6
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10978      +/-   ##
==========================================
- Coverage   50.06%   44.09%   -5.97%     
==========================================
  Files         178      178              
  Lines       14801    14801              
==========================================
- Hits         7410     6527     -883     
- Misses       6044     7071    +1027     
+ Partials     1347     1203     -144     
Flag Coverage Δ
e2etests 36.45% <0.00%> (-9.82%) ⬇️
inttests 36.73% <0.00%> (-0.01%) ⬇️
unittests 13.55% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit 0942e6a into k3s-io:master Oct 3, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants